Xuanwo commented on code in PR #5117:
URL: https://github.com/apache/opendal/pull/5117#discussion_r1759764262
##########
core/src/services/redis/backend.rs:
##########
@@ -299,26 +290,39 @@ impl Debug for Adapter {
}
impl Adapter {
- async fn conn(&self) -> Result<RedisConnection> {
- Ok(self
+ async fn conn(&self) -> Result<bb8::PooledConnection<'_,
RedisConnectionManager>> {
Review Comment:
Hi, thanks a lot for this PR first. Have you communicated with the upstream
first? I think it's a great feature that upstream might want to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
