Xuanwo commented on code in PR #5116:
URL: https://github.com/apache/opendal/pull/5116#discussion_r1765448523
##########
core/Cargo.toml:
##########
@@ -342,6 +343,11 @@ compio = { version = "0.11.0", optional = true, features =
[
] }
# for services-s3
crc32c = { version = "0.6.6", optional = true }
+# for services-nebula-graph
+rust-nebula = { version = "0.1", optional = true, git =
"https://github.com/nebula-contrib/rust-nebula";, features = [
Review Comment:
Hi, this could prevent us from making a new release.
##########
core/Cargo.toml:
##########
@@ -163,6 +163,7 @@ services-moka = ["dep:moka"]
services-mongodb = ["dep:mongodb"]
services-monoiofs = ["dep:monoio", "dep:flume"]
services-mysql = ["dep:sqlx", "sqlx?/mysql"]
+services-nebulagraph = ["dep:rust-nebula", "dep:bb8", "dep:snowflaked"]
Review Comment:
OpenDAL has strict naming pattern for service names.
Please either use:
- `nebulagraph` / `Nebulagraph`
or
- `nebula_graph` / `NebulaGraph`
In every place this name showed up.
##########
core/Cargo.lock:
##########
@@ -2770,6 +2860,12 @@ version = "2.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
checksum = "e6d5a32815ae3f33302d95fdcb2ce17862f8c65363dcfd29360480ba1001fc9c"
+[[package]]
+name = "futures"
+version = "0.1.31"
+source = "registry+https://github.com/rust-lang/crates.io-index";
+checksum = "3a471a38ef8ed83cd6e40aa59c1ffe17db6855c18e3604d9c4ed8c08ebc28678"
Review Comment:
Who is depending on `futures 0.1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
