PragmaTwice commented on code in PR #5186: URL: https://github.com/apache/opendal/pull/5186#discussion_r1802373246
########## bindings/c/README.md: ########## @@ -56,14 +56,13 @@ For more examples, please refer to `./examples` To build OpenDAL C binding, the following is all you need: -- **A C++ compiler** that supports **c++14**, _e.g._ clang++ and g++ +- A compiler that supports **C11** and **C++14**, _e.g._ clang and gcc - To format the code, you need to install **clang-format** - The `opendal.h` is not formatted by hands when you contribute, please do not format the file. **Use `make format` only.** - If your contribution is related to the files under `./tests`, you may format it before submitting your pull request. But notice that different versions of `clang-format` may format the files differently. -- **GTest(Google Test)** need to be installed to build the BDD (Behavior Driven Development) tests. To see how to build, check [here](https://github.com/google/googletest). Review Comment: Users don't need to manually install/build GTest by themselves now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
