erickguan opened a new pull request, #5213: URL: https://github.com/apache/opendal/pull/5213
# Which issue does this PR close? Part of #4746. # What changes are included in this PR? ftp service will also return last modified timestamp. # Are there any user-facing changes? Nope. # Questions I found other problems that I want to change but they are not part of the issue. 1. I also found the underlying crate `suppaftp` supports async. I want to support it. This might be a breaking change for FTP service. Do you consider support async for ftp? 2. I also see sftp implementation uses another crate `openssh_sftp_client`. I have skimmed through these crates documentation and code. I don't want to expand this comparasion too much. In short, `suppaftp` depends tls implementation in Rust while `openssh_sftp_client` depends on OpenSSH. `suppaftp` has slightly less code. I am considering using `suppaftp` if that fulfill the current implementation. Happy to discuss more. 3. I tested this locally by using a FTP server in Docker. Roughly put, how much tests do you consider to have and where to start? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
