PragmaTwice commented on code in PR #5208:
URL: https://github.com/apache/opendal/pull/5208#discussion_r1809198816
##########
core/src/raw/adapters/kv/api.rs:
##########
@@ -18,17 +18,28 @@
use std::fmt::Debug;
use std::future::ready;
+use futures::stream::Empty;
use futures::Future;
+use futures::Stream;
use crate::raw::*;
use crate::Capability;
use crate::Scheme;
use crate::*;
+/// A noop placeholder for Adapter::ScanIter
+pub type EmptyScanIter = Empty<Result<String>>;
Review Comment:
Done.
##########
core/src/raw/adapters/kv/backend.rs:
##########
@@ -182,19 +185,60 @@ impl<S: Adapter> Access for Backend<S> {
fn blocking_list(&self, path: &str, args: OpList) -> Result<(RpList,
Self::BlockingLister)> {
let p = build_abs_path(&self.root, path);
let res = self.kv.blocking_scan(&p)?;
- let lister = KvLister::new(&self.root, res);
+ let lister = BlockingKvLister::new(&self.root, res);
let lister = HierarchyLister::new(lister, path, args.recursive());
Ok((RpList::default(), lister))
}
}
-pub struct KvLister {
+pub struct KvLister<Iter> {
+ root: String,
+ inner: Mutex<Iter>,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
