jorgehermo9 commented on code in PR #5274: URL: https://github.com/apache/opendal/pull/5274#discussion_r1826555816
########## core/src/services/s3/core.rs: ########## @@ -462,7 +463,7 @@ impl S3Core { // Set user metadata headers. if let Some(user_metadata) = args.user_metadata() { for (key, value) in user_metadata { - req = req.header(format!("{}{}", constants::X_AMZ_META_PREFIX, key), value) + req = req.header(format!("{X_AMZ_META_PREFIX}{key}"), value) Review Comment: Changed this in order to be consistent with what I did in the azure part. It is more idiomatic to use string interpolation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org