This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 104727c86 refactor(core)!: Remove not used cap write_multi_align_size
(#5322)
104727c86 is described below
commit 104727c869c4e5aae79b46b5c7f913114cf1f6ad
Author: Xuanwo <[email protected]>
AuthorDate: Thu Nov 14 19:27:28 2024 +0800
refactor(core)!: Remove not used cap write_multi_align_size (#5322)
---
bindings/c/include/opendal.h | 8 --------
bindings/c/src/operator_info.rs | 7 -------
bindings/go/operator_info.go | 5 -----
bindings/go/types.go | 2 --
bindings/java/src/lib.rs | 3 +--
bindings/java/src/main/java/org/apache/opendal/Capability.java | 8 --------
.../src/test/java/org/apache/opendal/test/OperatorInfoTest.java | 2 --
bindings/nodejs/generated.d.ts | 6 ------
bindings/nodejs/src/capability.rs | 9 ---------
bindings/python/python/opendal/__init__.pyi | 1 -
bindings/python/src/capability.rs | 5 -----
bindings/ruby/src/capability.rs | 2 --
core/src/types/capability.rs | 3 ---
13 files changed, 1 insertion(+), 60 deletions(-)
diff --git a/bindings/c/include/opendal.h b/bindings/c/include/opendal.h
index 03e3eda75..76f84f933 100644
--- a/bindings/c/include/opendal.h
+++ b/bindings/c/include/opendal.h
@@ -515,14 +515,6 @@ typedef struct opendal_capability {
* If it is not set, this will be zero
*/
uintptr_t write_multi_min_size;
- /**
- * write_multi_align_size is the align size that services required in
write_multi.
- *
- * For example, Google GCS requires align size to 256KiB in write_multi.
- *
- * If it is not set, this will be zero
- */
- uintptr_t write_multi_align_size;
/**
* write_total_max_size is the max size that services support in write_total.
*
diff --git a/bindings/c/src/operator_info.rs b/bindings/c/src/operator_info.rs
index 4e42962a7..db96e99fe 100644
--- a/bindings/c/src/operator_info.rs
+++ b/bindings/c/src/operator_info.rs
@@ -89,12 +89,6 @@ pub struct opendal_capability {
///
/// If it is not set, this will be zero
pub write_multi_min_size: usize,
- /// write_multi_align_size is the align size that services required in
write_multi.
- ///
- /// For example, Google GCS requires align size to 256KiB in write_multi.
- ///
- /// If it is not set, this will be zero
- pub write_multi_align_size: usize,
/// write_total_max_size is the max size that services support in
write_total.
///
/// For example, Cloudflare D1 supports 1MB as max in write_total.
@@ -253,7 +247,6 @@ impl From<core::Capability> for opendal_capability {
write_with_cache_control: value.write_with_cache_control,
write_multi_max_size: value.write_multi_max_size.unwrap_or(0),
write_multi_min_size: value.write_multi_min_size.unwrap_or(0),
- write_multi_align_size: value.write_multi_align_size.unwrap_or(0),
write_total_max_size: value.write_total_max_size.unwrap_or(0),
create_dir: value.create_dir,
delete: value.delete,
diff --git a/bindings/go/operator_info.go b/bindings/go/operator_info.go
index 4a3c32afe..d9264b6c8 100644
--- a/bindings/go/operator_info.go
+++ b/bindings/go/operator_info.go
@@ -176,11 +176,6 @@ func (c *Capability) WriteMultiMaxSize() uint {
func (c *Capability) WriteMultiMinSize() uint {
return c.inner.writeMultiMinSize
}
-
-func (c *Capability) WriteMultiAlignSize() uint {
- return c.inner.writeMultiAlignSize
-}
-
func (c *Capability) WriteTotalMaxSize() uint {
return c.inner.writeTotalMaxSize
}
diff --git a/bindings/go/types.go b/bindings/go/types.go
index 5751f0cdb..d5bd92495 100644
--- a/bindings/go/types.go
+++ b/bindings/go/types.go
@@ -147,7 +147,6 @@ var (
&ffi.TypeUint8, // write_with_cache_control
&ffi.TypePointer, // write_multi_max_size
&ffi.TypePointer, // write_multi_min_size
- &ffi.TypePointer, // write_multi_align_size
&ffi.TypePointer, // write_total_max_size
&ffi.TypeUint8, // create_dir
&ffi.TypeUint8, // delete
@@ -189,7 +188,6 @@ type opendalCapability struct {
writeWithCacheControl uint8
writeMultiMaxSize uint
writeMultiMinSize uint
- writeMultiAlignSize uint
writeTotalMaxSize uint
createDir uint8
delete uint8
diff --git a/bindings/java/src/lib.rs b/bindings/java/src/lib.rs
index 47113ae74..a9fef7e65 100644
--- a/bindings/java/src/lib.rs
+++ b/bindings/java/src/lib.rs
@@ -94,7 +94,7 @@ fn make_operator_info<'a>(env: &mut JNIEnv<'a>, info:
OperatorInfo) -> Result<JO
fn make_capability<'a>(env: &mut JNIEnv<'a>, cap: Capability) ->
Result<JObject<'a>> {
let capability = env.new_object(
"org/apache/opendal/Capability",
- "(ZZZZZZZZZZZZZZZJJJZZZZZZZZZZZZZZJZ)V",
+ "(ZZZZZZZZZZZZZZZJJZZZZZZZZZZZZZZJZ)V",
&[
JValue::Bool(cap.stat as jboolean),
JValue::Bool(cap.stat_with_if_match as jboolean),
@@ -113,7 +113,6 @@ fn make_capability<'a>(env: &mut JNIEnv<'a>, cap:
Capability) -> Result<JObject<
JValue::Bool(cap.write_with_cache_control as jboolean),
JValue::Long(convert::usize_to_jlong(cap.write_multi_max_size)),
JValue::Long(convert::usize_to_jlong(cap.write_multi_min_size)),
- JValue::Long(convert::usize_to_jlong(cap.write_multi_align_size)),
JValue::Bool(cap.create_dir as jboolean),
JValue::Bool(cap.delete as jboolean),
JValue::Bool(cap.copy as jboolean),
diff --git a/bindings/java/src/main/java/org/apache/opendal/Capability.java
b/bindings/java/src/main/java/org/apache/opendal/Capability.java
index 40c9eee83..30404d636 100644
--- a/bindings/java/src/main/java/org/apache/opendal/Capability.java
+++ b/bindings/java/src/main/java/org/apache/opendal/Capability.java
@@ -110,12 +110,6 @@ public class Capability {
*/
public final long writeMultiMinSize;
- /**
- * write_multi_align_size is the align size that services required in
write_multi.
- * For example, Google GCS requires align size to 256KiB in write_multi.
- */
- public final long writeMultiAlignSize;
-
/**
* If operator supports create dir.
*/
@@ -214,7 +208,6 @@ public class Capability {
boolean writeWithCacheControl,
long writeMultiMaxSize,
long writeMultiMinSize,
- long writeMultiAlignSize,
boolean createDir,
boolean delete,
boolean copy,
@@ -248,7 +241,6 @@ public class Capability {
this.writeWithCacheControl = writeWithCacheControl;
this.writeMultiMaxSize = writeMultiMaxSize;
this.writeMultiMinSize = writeMultiMinSize;
- this.writeMultiAlignSize = writeMultiAlignSize;
this.createDir = createDir;
this.delete = delete;
this.copy = copy;
diff --git
a/bindings/java/src/test/java/org/apache/opendal/test/OperatorInfoTest.java
b/bindings/java/src/test/java/org/apache/opendal/test/OperatorInfoTest.java
index dc3174cc7..cef3401d0 100644
--- a/bindings/java/src/test/java/org/apache/opendal/test/OperatorInfoTest.java
+++ b/bindings/java/src/test/java/org/apache/opendal/test/OperatorInfoTest.java
@@ -48,7 +48,6 @@ public class OperatorInfoTest {
assertThat(info.fullCapability.write).isTrue();
assertThat(info.fullCapability.delete).isTrue();
assertThat(info.fullCapability.writeCanAppend).isTrue();
- assertThat(info.fullCapability.writeMultiAlignSize).isEqualTo(-1);
assertThat(info.fullCapability.writeMultiMaxSize).isEqualTo(-1);
assertThat(info.fullCapability.writeMultiMinSize).isEqualTo(-1);
assertThat(info.fullCapability.batchMaxOperations).isEqualTo(-1);
@@ -71,7 +70,6 @@ public class OperatorInfoTest {
assertThat(info.fullCapability.write).isTrue();
assertThat(info.fullCapability.delete).isTrue();
assertThat(info.fullCapability.writeCanAppend).isFalse();
- assertThat(info.fullCapability.writeMultiAlignSize).isEqualTo(-1);
assertThat(info.fullCapability.writeMultiMaxSize).isEqualTo(-1);
assertThat(info.fullCapability.writeMultiMinSize).isEqualTo(-1);
assertThat(info.fullCapability.batchMaxOperations).isEqualTo(-1);
diff --git a/bindings/nodejs/generated.d.ts b/bindings/nodejs/generated.d.ts
index f16b29c27..7b5ade3c8 100644
--- a/bindings/nodejs/generated.d.ts
+++ b/bindings/nodejs/generated.d.ts
@@ -156,12 +156,6 @@ export class Capability {
* For example, AWS S3 requires at least 5MiB in write_multi expect the last
one.
*/
get writeMultiMinSize(): bigint | null
- /**
- * write_multi_align_size is the align size that services required in
write_multi.
- *
- * For example, Google GCS requires align size to 256KiB in write_multi.
- */
- get writeMultiAlignSize(): bigint | null
/**
* write_total_max_size is the max size that services support in write_total.
*
diff --git a/bindings/nodejs/src/capability.rs
b/bindings/nodejs/src/capability.rs
index 075196f90..66fcb5c64 100644
--- a/bindings/nodejs/src/capability.rs
+++ b/bindings/nodejs/src/capability.rs
@@ -147,15 +147,6 @@ impl Capability {
pub fn write_multi_min_size(&self) -> Option<usize> {
self.0.write_multi_min_size
}
-
- /// write_multi_align_size is the align size that services required in
write_multi.
- ///
- /// For example, Google GCS requires align size to 256KiB in write_multi.
- #[napi(getter)]
- pub fn write_multi_align_size(&self) -> Option<usize> {
- self.0.write_multi_align_size
- }
-
/// write_total_max_size is the max size that services support in
write_total.
///
/// For example, Cloudflare D1 supports 1MB as max in write_total.
diff --git a/bindings/python/python/opendal/__init__.pyi
b/bindings/python/python/opendal/__init__.pyi
index 64fedbbf0..2a2ae246b 100644
--- a/bindings/python/python/opendal/__init__.pyi
+++ b/bindings/python/python/opendal/__init__.pyi
@@ -182,7 +182,6 @@ class Capability:
write_with_cache_control: bool
write_multi_max_size: Optional[int]
write_multi_min_size: Optional[int]
- write_multi_align_size: Optional[int]
write_total_max_size: Optional[int]
create_dir: bool
diff --git a/bindings/python/src/capability.rs
b/bindings/python/src/capability.rs
index bcd98b32c..6cc76e153 100644
--- a/bindings/python/src/capability.rs
+++ b/bindings/python/src/capability.rs
@@ -63,10 +63,6 @@ pub struct Capability {
///
/// For example, AWS S3 requires at least 5MiB in write_multi expect the
last one.
pub write_multi_min_size: Option<usize>,
- /// write_multi_align_size is the align size that services required in
write_multi.
- ///
- /// For example, Google GCS requires align size to 256KiB in write_multi.
- pub write_multi_align_size: Option<usize>,
/// write_total_max_size is the max size that services support in
write_total.
///
/// For example, Cloudflare D1 supports 1MB as max in write_total.
@@ -135,7 +131,6 @@ impl Capability {
write_with_cache_control: capability.write_with_cache_control,
write_multi_max_size: capability.write_multi_max_size,
write_multi_min_size: capability.write_multi_min_size,
- write_multi_align_size: capability.write_multi_align_size,
write_total_max_size: capability.write_total_max_size,
create_dir: capability.create_dir,
delete: capability.delete,
diff --git a/bindings/ruby/src/capability.rs b/bindings/ruby/src/capability.rs
index 01a9676b2..a2402dceb 100644
--- a/bindings/ruby/src/capability.rs
+++ b/bindings/ruby/src/capability.rs
@@ -79,7 +79,6 @@ define_accessors!(Capability, {
write_with_user_metadata: bool,
write_multi_max_size: Option<usize>,
write_multi_min_size: Option<usize>,
- write_multi_align_size: Option<usize>,
write_total_max_size: Option<usize>,
create_dir: bool,
delete: bool,
@@ -130,7 +129,6 @@ pub fn include(gem_module: &RModule) -> Result<(), Error> {
write_with_user_metadata,
write_multi_max_size,
write_multi_min_size,
- write_multi_align_size,
write_total_max_size,
create_dir,
delete,
diff --git a/core/src/types/capability.rs b/core/src/types/capability.rs
index c81ada644..b30cbf880 100644
--- a/core/src/types/capability.rs
+++ b/core/src/types/capability.rs
@@ -140,9 +140,6 @@ pub struct Capability {
/// Minimum size required for multipart uploads (except for the last part).
/// For example, AWS S3 requires at least 5MiB per part.
pub write_multi_min_size: Option<usize>,
- /// Required size alignment for multipart uploads.
- /// For example, Google GCS requires 256KiB alignment.
- pub write_multi_align_size: Option<usize>,
/// Maximum total size supported for write operations.
/// For example, Cloudflare D1 has a 1MB total size limit.
pub write_total_max_size: Option<usize>,
