Xuanwo commented on code in PR #5500:
URL: https://github.com/apache/opendal/pull/5500#discussion_r1901751145
##########
core/src/raw/chrono_util.rs:
##########
@@ -62,3 +62,10 @@ pub fn parse_datetime_from_from_timestamp(s: i64) ->
Result<DateTime<Utc>> {
Ok(st.into())
}
+
+/// format datetime to rfc1123
+///
+/// for example: `Sun, 06 Nov 1994 08:49:37 GMT`
+pub fn to_rfc_1123(s: DateTime<Utc>) -> String {
Review Comment:
I suggest to use `format_datetime_into_http_date` as API name.
Besides, how about adding a test case for this? We can use the time in the
RFC: `Sat, 29 Oct 1994 19:43:31 GMT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
