Xuanwo commented on code in PR #5561: URL: https://github.com/apache/opendal/pull/5561#discussion_r1919615638
########## core/src/services/s3/backend.rs: ########## @@ -512,6 +512,7 @@ impl S3Builder { // Update with endpoint templates. endpoint = if let Some(template) = ENDPOINT_TEMPLATES.get(endpoint.as_str()) { + #[allow(clippy::literal_string_with_formatting_args)] template.replace("{region}", region) Review Comment: In that case, it's a false positive. Perhaps we could raise an issue with Clippy instead. `std::replace()` takes a `Pattern` instead of a `format_args()`, it doesn't make sense to check this here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org