Xuanwo commented on PR #5563: URL: https://github.com/apache/opendal/pull/5563#issuecomment-2601846824
> yes but this doctest I think its better to ignore here, cause for developers the most simple and intuitions do is `cargo build` and `cargo test` Yep, that's why I think updating guide is a better idea. It would also be beneficial to migrate all doc tests to memory services, allowing us to avoid dependence on the `tests` feature. > and for now for opendal I do not see any directly doctest in the repo and actions. Hi, I didn't understand this. Nearly all of OpenDAL's public API includes a corresponding doc test as an example. For example: https://github.com/apache/opendal/blob/c4da0505d8bc473da8996d19a9c7335b7d91339a/core/src/types/operator/operator.rs#L62-L75 > the way run all the unit tests is `cargo test --all-features`, but for the most os and developers part is also hard to run, for We should not encourage developers to run `--all-features`; we can't even do this in CI. I don't remember if we have commands like this. If we do, it's better to update them. I understand that it might be frustrating that you can't run all unit tests locally. However, this is due to the complexities we encounter within OpenDAL (and the service it support). We strongly encourage you to simply submit PRs and let the CI perform the checks, addressing any issues only if the CI fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
