meteorgan commented on code in PR #5562:
URL: https://github.com/apache/opendal/pull/5562#discussion_r1923629421


##########
core/src/raw/adapters/kv/backend.rs:
##########
@@ -297,9 +297,11 @@ impl<S: Adapter> oio::Write for KvWriter<S> {
         Ok(())
     }
 
-    async fn close(&mut self) -> Result<()> {
+    async fn close(&mut self) -> Result<Metadata> {
         let buf = self.buffer.clone().collect();
-        self.kv.set(&self.path, buf).await
+        self.kv.set(&self.path, buf).await?;
+
+        Ok(Metadata::default())

Review Comment:
   But there is still an issue - what about `append` ? Can we have a simple 
method to retrieve the `content_length` without performing a `stat` or parsing 
the result of `append` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to