Xuanwo commented on code in PR #5601:
URL: https://github.com/apache/opendal/pull/5601#discussion_r1948432154
##########
bin/ofs/Cargo.lock:
##########
Review Comment:
Hi, please don't touch unrelated files.
##########
core/src/services/swift/backend.rs:
##########
@@ -221,12 +223,24 @@ impl Access for SwiftBackend {
async fn stat(&self, path: &str, _args: OpStat) -> Result<RpStat> {
let resp = self.core.swift_get_metadata(path).await?;
+ debug!(
+ "swift: stat operation for path {}, response status: {}",
+ path,
+ resp.status()
+ );
- let status = resp.status();
-
- match status {
+ match resp.status() {
StatusCode::OK | StatusCode::NO_CONTENT => {
- let meta = parse_into_metadata(path, resp.headers())?;
+ let headers = resp.headers();
+ let mut meta = parse_into_metadata(path, headers)?;
+ // 添加日志:记录解析前的原始头部
Review Comment:
The same.
##########
core/src/services/swift/backend.rs:
##########
@@ -221,12 +223,24 @@ impl Access for SwiftBackend {
async fn stat(&self, path: &str, _args: OpStat) -> Result<RpStat> {
let resp = self.core.swift_get_metadata(path).await?;
+ debug!(
Review Comment:
Please remove debug lins like this.
##########
core/src/services/swift/core.rs:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+use log::debug;
Review Comment:
Please don't add debug links in services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]