Xuanwo commented on code in PR #5647:
URL: https://github.com/apache/opendal/pull/5647#discussion_r1967153193
##########
core/tests/behavior/async_presign.rs:
##########
@@ -31,12 +31,13 @@ use crate::*;
pub fn tests(op: &Operator, tests: &mut Vec<Trial>) {
let cap = op.info().full_capability();
- if cap.read && cap.write && cap.presign {
+ if cap.read && cap.write && cap.presign && cap.delete {
Review Comment:
This will skip all tests for presign. How about implement in this way:
```
if cap.read && cap.write && cap.presign {
tests.extend(async_trials!(
op,
test_presign_write,
test_presign_read,
test_presign_stat
))
}
if cap.read && cap.write && cap.presign && cap.delete {
tests.extend(async_trials!(
op,
test_presign_delete
))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
