meteorgan commented on code in PR #5762:
URL: https://github.com/apache/opendal/pull/5762#discussion_r1996953545
##########
core/src/raw/ops.rs:
##########
@@ -44,6 +44,21 @@ impl OpCreateDir {
#[derive(Debug, Clone, Default, Eq, Hash, PartialEq)]
pub struct OpDelete {
version: Option<String>,
+ /// The `recursive` is used to control whether the delete operation is
recursive.
+ ///
+ /// if `false`, delete operation will only delete the given path.
+ /// if `true`, delete operation will delete all entries that starts with
given path.
+ ///
+ /// Default to `false`.
+ recursive: bool,
+ /// The `versions` is used to control whether the object versions should
be deleted.
+ ///
+ /// if `false`, delete operation will only delete the latest version.
+ /// if `true`, delete operation will delete all the object versions if
object versioning is supported
+ /// by the underlying service.
+ ///
+ /// Default to `false`.
+ versions: bool,
Review Comment:
We can use the same approach for recursive deletion. So, is supporting
`delete_with().recursive()` only useful when the underlying service supports
`delete_with_recursive` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
