cuichenli commented on code in PR #5718:
URL: https://github.com/apache/opendal/pull/5718#discussion_r2001288475
##########
bindings/java/src/main/java/org/apache/opendal/Operator.java:
##########
@@ -53,7 +54,7 @@ public static Operator of(ServiceConfig config) {
*/
public static Operator of(String scheme, Map<String, String> map) {
try (final AsyncOperator operator = AsyncOperator.of(scheme, map)) {
- return operator.blocking();
+ return operator.layer(new CompleteLayer()).blocking();
Review Comment:
doing the layer on java side as i did not find a way to do it on rust side
for blocking operator. again let me know if that is not suitable.
##########
bindings/java/src/async_operator.rs:
##########
@@ -576,22 +579,41 @@ fn intern_list(
op: *mut Operator,
executor: *const Executor,
path: JString,
+ options: JObject,
) -> Result<jlong> {
let op = unsafe { &mut *op };
let id = request_id(env)?;
let path = jstring_to_string(env, &path)?;
+ let recursive = if env.call_method(&options, "isRecursive", "()Z",
&[])?.z()? {
Review Comment:
i had some trouble on passing the options to the async block so that is the
best way i can do. please let me know if that is not suitable, i may need some
help on how to pass this arround. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
