meteorgan commented on code in PR #5960:
URL: https://github.com/apache/opendal/pull/5960#discussion_r2030111767
##########
core/src/types/metadata.rs:
##########
@@ -429,7 +429,7 @@ impl Metadata {
}
/// Set user defined metadata of this entry
- pub fn with_user_metadata(&mut self, data: HashMap<String, String>) ->
&mut Self {
+ pub fn set_user_metadata(&mut self, data: HashMap<String, String>) -> &mut
Self {
Review Comment:
> * `set_xxx` accepts a borrowed type,
This is not always true. Both `set_content_range` and `set_last_modified`
also accept an owned type. In current implementation, `set_xxx` is typically
used when the returned value is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
