ozewr commented on code in PR #5471:
URL: https://github.com/apache/opendal/pull/5471#discussion_r2035214105
##########
core/src/services/memcached/binary.rs:
##########
@@ -98,11 +98,11 @@ pub struct Response {
}
pub struct Connection {
- io: BufReader<TcpStream>,
+ io: BufReader<Box<dyn Connect>>,
}
Review Comment:
This might not be a good
implementation.https://github.com/apache/opendal/blob/f66cf1f3dfc1d43e52d8cdb7a7225f72dbcbabd7/core/src/services/memcached/backend.rs#L262-L264
This implementation returns a concrete type `Self::Connection`. If we try to
use generics here, it would cause a conflict where a single function attempts
to return two different types.That's because IO is a concrete type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
