miroim opened a new pull request, #6002: URL: https://github.com/apache/opendal/pull/6002
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> # Rationale for this change > Could we take it a step further and build a function like `pub async fn IpfsCore::ipfs_stat(name: &str) -> Result<Metadata>`? This would allow you to retrieve metadata for each name directly via the core for `DirStream`. _Originally posted by @erickguan in https://github.com/apache/opendal/pull/5950#discussion_r2029422349_ This pull request refactors the IPFS backend implementation to simplify the code and improve maintainability. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? The main changes involve moving the `stat` logic from `IpfsBackend` to `IpfsCore`, updating the `DirStream` structure <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking-changes` label. --> # Beahvior test log <details> <summary>cargo test behavior --features tests,services-ipfs -- --show-output</summary> ``` running 23 tests test behavior::test_read_only_read_full ... ok test behavior::test_read_only_read_full_with_special_chars ... ok test behavior::test_read_only_read_with_dir_path ... ok test behavior::test_read_only_read_with_if_match ... ok test behavior::test_read_only_read_with_if_none_match ... ok test behavior::test_reader_only_read_with_if_match ... ok test behavior::test_reader_only_read_with_if_none_match ... ok test behavior::test_read_only_read_with_range ... ok test behavior::test_read_only_read_not_exist ... ok test behavior::test_read_only_stat_not_cleaned_path ... ok test behavior::test_read_only_stat_file_and_dir ... ok test behavior::test_read_only_stat_with_if_match ... ok test behavior::test_read_only_stat_with_if_none_match ... ok test behavior::test_read_only_stat_root ... ok test behavior::test_read_only_stat_special_chars ... ok test behavior::test_read_only_stat_not_exist ... ok test behavior::test_blocking_read_only_stat_not_exist ... ok test behavior::test_blocking_read_only_stat_special_chars ... ok test behavior::test_blocking_read_only_stat_file_and_dir ... ok test behavior::test_blocking_read_only_read_not_exist ... ok test behavior::test_blocking_read_only_read_with_range ... ok test behavior::test_blocking_read_only_read_full ... ok test behavior::test_list_only ... ok test result: ok. 23 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
