Xuanwo commented on code in PR #5456: URL: https://github.com/apache/opendal/pull/5456#discussion_r2051737733
########## integrations/object_store/src/s3_builder.rs: ########## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::utils::format_object_store_error; +use crate::OpendalStore; +use object_store::aws::AmazonS3ConfigKey; +use opendal::services::S3; +use opendal::Operator; + +pub struct S3Builder { + builder: S3, +} + +impl Default for S3Builder { + fn default() -> Self { + Self::new() + } +} + +impl S3Builder { + pub fn new() -> Self { + S3Builder { + builder: S3::default(), + } + } + + pub fn root(mut self, root_path: impl Into<String>) -> Self { Review Comment: Mapping all APIs from `object_store` seems like a lot of work. Could we just accept an `object_store` Builder instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
