antoninferrand commented on code in PR #6070:
URL: https://github.com/apache/opendal/pull/6070#discussion_r2051770475
##########
core/src/services/s3/core.rs:
##########
@@ -606,7 +632,12 @@ impl S3Core {
url.push_str(&format!("?{}", query_args.join("&")));
}
- let mut req = Request::delete(&url)
+ let mut req = Request::delete(&url);
+
Review Comment:
> I really do like this chained syntax, a lot more cleaner than let req = ...
https://github.com/apache/opendal/pull/6068#discussion_r2051715640
Same but I don't think I have the choice here, as adding the new header is
optional..
But if you see a better alternative, I would be glad to use it instead !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
