jorgehermo9 commented on code in PR #6089:
URL: https://github.com/apache/opendal/pull/6089#discussion_r2061281278
##########
core/src/services/aliyun_drive/backend.rs:
##########
@@ -370,12 +368,8 @@ impl Access for AliyunDriveBackend {
serde_json::from_reader(res.reader()).map_err(new_json_serialize_error)?;
let download_url = self.core.get_download_url(&file.file_id).await?;
- let req = Request::get(&download_url)
- .header(header::RANGE, args.range().to_header())
- .body(Buffer::new())
- .map_err(new_request_build_error)?;
+ let resp = self.core.download(&download_url, args.range()).await?;
Review Comment:
Same as https://github.com/apache/opendal/pull/6090/files#r2061281070.
Should we move both `get_download_url` and `download(download_url)` into a
single method `download_file` in core?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
