jorgehermo9 commented on code in PR #6102:
URL: https://github.com/apache/opendal/pull/6102#discussion_r2062581285
##########
core/src/services/azblob/core.rs:
##########
@@ -428,7 +465,7 @@ impl AzblobCore {
self.send(req).await
}
- pub fn azblob_complete_put_block_list_request(
+ fn azblob_complete_put_block_list_request(
Review Comment:
changed internal functions to private visibility. Other `*_request`
functions such as `azblob_get_blob_request` needs to be private because they're
used to get presign urls in `backend.rs`
##########
core/src/services/azblob/core.rs:
##########
@@ -428,7 +465,7 @@ impl AzblobCore {
self.send(req).await
}
- pub fn azblob_complete_put_block_list_request(
+ fn azblob_complete_put_block_list_request(
Review Comment:
changed some internal functions to private visibility. Other `*_request`
functions such as `azblob_get_blob_request` needs to be private because they're
used to get presign urls in `backend.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
