kingsword09 opened a new pull request, #6266:
URL: https://github.com/apache/opendal/pull/6266

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements. You can link an issue to this PR using the GitHub syntax. For 
example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6237.
   
   # Rationale for this change
   <!--
   Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.
   -->
   Supports both ES modules and CommonJS.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   There's already #6258 addressing this issue, but it hasn't been merged yet. 
My fix can support both ES modules and CommonJS in Node.js, and in Next.js, you 
just need to add `serverExternalPackages: ['opendal']` to make it work properly.
   ```js
   /** @type {import('next').NextConfig} */
   const nextConfig = {
     serverExternalPackages: ['opendal'],
   }
   
   module.exports = nextConfig
   ```
   
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the 
`breaking-changes` label.
   -->
   Encountered issues while using opendal in Node.js ESModule.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to