Xuanwo commented on PR #6326: URL: https://github.com/apache/opendal/pull/6326#issuecomment-2993923573
> @Xuanwo At first, I also thought this part was functional, but there's an extra `tmp_path` here. When the `atomic_write_dir` exists, a `tmp_path` gets generated, causing every write operation to use new `tmp_path` instead. As a result, the `ConditionNotMatch` exception won't be thrown. > > > > https://github.com/apache/opendal/blob/577912dfeaa2fcdb0de794607d8c45bf76cb419b/core/src/services/fs/core.rs#L162 I see. So the real fix should use the correct open options to open the target path. In this way, we can avoid an extra syscall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
