JackDrogon commented on PR #6298: URL: https://github.com/apache/opendal/pull/6298#issuecomment-3064702576
@asukaminato0721 This implementation is a bit complex. The Rust bridge to C++ part of the code should be a bit thinner. Whether it is unsafe or not is not a big deal. This is because the C++ binding does not affect the Rust code, but rather the C++ part. Furthermore, the binding part of the code is only used to bypass Rust's restrictions, which is relatively controllable. If removing unsafe introduces too much complexity (global storage ID), then it is not worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
