Xuanwo commented on code in PR #6296:
URL: https://github.com/apache/opendal/pull/6296#discussion_r2202345156
##########
bindings/cpp/CMakeLists.txt:
##########
@@ -191,13 +191,34 @@ if (OPENDAL_ENABLE_TESTING)
FetchContent_MakeAvailable(cppcoro)
endif()
+ # Test framework and main runner
+ list(APPEND TEST_SOURCE_FILE tests/test_main.cpp)
+
+ # Legacy tests for compatibility
list(APPEND TEST_SOURCE_FILE tests/basic_test.cpp)
if (OPENDAL_ENABLE_ASYNC)
list(APPEND TEST_SOURCE_FILE tests/async_test.cpp)
endif()
+
+ # Behavior tests
+ list(APPEND TEST_SOURCE_FILE tests/behavior/read_test.cpp)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/write_test.cpp)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/delete_test.cpp)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/list_test.cpp)
+
+ # Async behavior tests (only if async is enabled)
+ if (OPENDAL_ENABLE_ASYNC)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/async_read_test.cpp)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/async_write_test.cpp)
+ list(APPEND TEST_SOURCE_FILE tests/behavior/async_list_test.cpp)
+ endif()
+
+ # Benchmark tests
+ list(APPEND TEST_SOURCE_FILE tests/benchmark/benchmark_test.cpp)
Review Comment:
Please don't run benchmark in behavior tests. We don't have money for them.
##########
bindings/cpp/include/opendal.hpp:
##########
@@ -147,6 +147,13 @@ class Operator {
*/
void remove(std::string_view path);
+ /**
+ * @brief Remove all files and directories recursively
+ *
+ * @param path The path of the directory to remove recursively
+ */
+ void remove_all(std::string_view path);
Review Comment:
This API will be removed in the future. Let's just don't add them if not
requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
