Xuanwo commented on code in PR #6468: URL: https://github.com/apache/opendal/pull/6468#discussion_r2248307989
########## integrations/object_store/src/store.rs: ########## @@ -206,15 +242,47 @@ impl ObjectStore for OpendalStore { async fn put_multipart_opts( &self, - _location: &Path, - _opts: PutMultipartOptions, + location: &Path, + opts: PutMultipartOptions, ) -> object_store::Result<Box<dyn MultipartUpload>> { - Err(object_store::Error::NotSupported { - source: Box::new(opendal::Error::new( - opendal::ErrorKind::Unsupported, - "put_multipart_opts is not implemented so far", - )), - }) + let mut writer_builder = self + .inner + .writer_with(&percent_decode_path(location.as_ref())) + .concurrent(8); + + // Handle attributes if provided + for (key, value) in opts.attributes.iter() { + match key { + object_store::Attribute::CacheControl => { + writer_builder = writer_builder.cache_control(value); Review Comment: I wish we can use `opendal::options::WriteOptions` instead of builder here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org