Xuanwo commented on code in PR #6531:
URL: https://github.com/apache/opendal/pull/6531#discussion_r2315586195
##########
core/src/services/s3/backend.rs:
##########
@@ -600,6 +611,19 @@ impl S3Builder {
self
}
+ /// Enable the use of S3 bucket keys for server-side encryption.
+ /// This can reduce costs when using KMS encryption by using fewer KMS API
calls.
+ pub fn enable_server_side_encryption_bucket_key(mut self) -> Self {
Review Comment:
I'm hesitant about this because OpenDAL tends to maintain configuration
values in an orthogonal way, meaning each configuration value controls only a
single feature. Users don't need to worry about the interactions between
configuration values.
But I do understand the value of be compatible to those object_store
options. Is it a good idea to add those mapping in to `object_store_opendal`?
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
