tisonkun commented on code in PR #6643:
URL: https://github.com/apache/opendal/pull/6643#discussion_r2420835274
##########
core/src/lib.rs:
##########
@@ -181,8 +181,8 @@ mod tests {
#[test]
fn assert_size() {
assert_eq!(16, size_of::<Operator>());
- assert_eq!(320, size_of::<Entry>());
- assert_eq!(296, size_of::<Metadata>());
+ assert_eq!(360, size_of::<Entry>());
+ assert_eq!(336, size_of::<Metadata>());
Review Comment:
Thanks for your detailed explanation! 16 bytes are reasonable given the
design above.
As a supplement, in ScopeDB, we assume all timestamps and durations can be
represented in i64 in nanoseconds (it gives a relatively long range already) so
we use 8 bytes i64 during store/load to make it more compact. But it's an
application-specific improvement and when doing business, we cast them back to
jiff's types for all the methods it provides :D
> Jiff does not use this representation for a timestamp type though ...
Totally make sense. I checked all these types' implementation and learn a
lot. Thank you :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
