tisonkun commented on code in PR #634:
URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2377732252
##########
services/azure-storage/src/provide_credential/azure_cli.rs:
##########
@@ -96,12 +96,12 @@ impl ProvideCredential for AzureCliCredentialProvider {
// Calculate expiration time
let expires_on = if let Some(timestamp) = token.expires_on_timestamp {
- Some(chrono::DateTime::from_timestamp(timestamp, 0).unwrap())
+ Some(jiff::Timestamp::new(timestamp, 0).unwrap())
Review Comment:
Yes. I keep the diff minor for review. Now we can use the tighter form :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]