bonsairobo commented on issue #6599:
URL: https://github.com/apache/opendal/issues/6599#issuecomment-3345139857

   @Xuanwo I'd be happy to. I might need some help scoping this work. I'm aware 
of this error display issue, but I bet there is a similar issue in things like 
the `LoggingLayer`. Can you think of any others? Ideally we would be able to 
use some newtype to guarantee we don't leak the sensitive info, but I'm not 
sure how feasible that is when we're working with the `http::Uri` type.
   
   I see that the function `with_error_response_context` is adding the `uri` 
field. I figured I should just hide/replace any query params from the set of 
SAS token params, but I'm not sure if there might be param name conflicts with 
other services. The full set of query params depends on the type of SAS token. 
I was thinking maybe it could work to just check the context for the 
`"service"` field to be `"azblob"`, but it's private at the moment. Would it be 
OK to expose this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to