tisonkun commented on code in PR #6820:
URL: https://github.com/apache/opendal/pull/6820#discussion_r2559773613
##########
core/src/services/etcd/core.rs:
##########
@@ -77,26 +75,34 @@ impl Debug for EtcdCore {
}
impl EtcdCore {
- pub async fn conn(&self) -> Result<PooledConnection<'static, Manager>> {
- let client = self
- .client
- .get_or_try_init(|| async {
- Pool::builder()
- .max_size(64)
- .build(Manager {
- endpoints: self.endpoints.clone(),
- options: self.options.clone(),
- })
- .await
- })
- .await?;
-
- client.get_owned().await.map_err(|err| match err {
- RunError::User(err) => err,
- RunError::TimedOut => {
- Error::new(ErrorKind::Unexpected, "connection request:
timeout").set_temporary()
+ pub fn new(endpoints: Vec<String>, options: ConnectOptions) -> Self {
+ let client = bounded::Pool::new(
+ bounded::PoolConfig::new(64),
+ Manager {
+ endpoints: endpoints.clone(),
+ options: options.clone(),
+ },
+ );
+
Review Comment:
To add an idle_timeout feature, we may follow-up
https://github.com/fast/fastpool/blob/355fb6769c6144220410114de307f5f793b61cb8/examples/postgres/src/main.rs#L40-L59
But let's only add it when it's really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
