Copilot commented on code in PR #6965: URL: https://github.com/apache/opendal/pull/6965#discussion_r2609107602
########## core/layers/fastrace/Cargo.toml: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +description = "Apache OpenDAL fastrace layer" +name = "opendal-layer-fastrace" + +authors = { workspace = true } +edition = { workspace = true } +homepage = { workspace = true } +license = { workspace = true } +repository = { workspace = true } +rust-version = { workspace = true } +version = { workspace = true } + +[package.metadata.docs.rs] +all-features = true + +[dependencies] +fastrace = "0.7.14" +opendal-core = { path = "../../core", version = "0.55.0", default-features = false, features = ["services-memory"] } Review Comment: The dependency on opendal-core includes the `services-memory` feature, which is inconsistent with other layer crates in this repository. Other layer crates like `opendal-layer-fastmetrics`, `opendal-layer-metrics`, `opendal-layer-async-backtrace`, etc., do not include this feature. The `services-memory` feature is only needed in dev-dependencies for documentation examples and tests, but should not be part of the main dependencies as it unnecessarily couples the layer to a specific service implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
