Xuanwo commented on code in PR #6961: URL: https://github.com/apache/opendal/pull/6961#discussion_r2609373949
########## core/core/src/layers/mod.rs: ########## @@ -52,6 +52,7 @@ mod mime_guess; #[cfg(feature = "layers-mime-guess")] pub use self::mime_guess::MimeGuessLayer; +#[path = "../../../layers/retry/src/lib.rs"] Review Comment: Hi, please check our tracking issue https://github.com/apache/opendal/issues/6829 again, this is not we want. ########## core/layers/retry/src/lib.rs: ########## @@ -409,7 +409,9 @@ impl<A: Access> oio::Read for RetryReader<A, A::Reader> { Some(mut reader) => { let buf = reader.read().await?; self.reader = Some(reader); - self.args.range_mut().advance(buf.len() as u64); + let mut range = self.args.range(); Review Comment: This change seems not needed, please don't touch our layer's impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
