Xuanwo commented on code in PR #6978:
URL: https://github.com/apache/opendal/pull/6978#discussion_r2613746921
##########
core/services/oss/src/backend.rs:
##########
@@ -36,13 +37,15 @@ use super::lister::OssListers;
use super::lister::OssObjectVersionsLister;
use super::writer::OssWriter;
use super::writer::OssWriters;
-use crate::raw::*;
-use crate::*;
+use opendal_core::raw::*;
+use opendal_core::*;
+
+static GLOBAL_REQWEST_CLIENT: LazyLock<reqwest::Client> =
LazyLock::new(reqwest::Client::new);
const DEFAULT_BATCH_MAX_OPERATIONS: usize = 1000;
/// Aliyun Object Storage Service (OSS) support
-#[doc = include_str!("docs.md")]
+#[doc = include_str!("../docs.md")]
Review Comment:
Why this change?
##########
core/services/oss/src/backend.rs:
##########
@@ -36,13 +37,15 @@ use super::lister::OssListers;
use super::lister::OssObjectVersionsLister;
use super::writer::OssWriter;
use super::writer::OssWriters;
-use crate::raw::*;
-use crate::*;
+use opendal_core::raw::*;
+use opendal_core::*;
+
+static GLOBAL_REQWEST_CLIENT: LazyLock<reqwest::Client> =
LazyLock::new(reqwest::Client::new);
Review Comment:
Please use the `GLOBAL_REQWEST_CLIENT` from `opendal_core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
