Xuanwo commented on code in PR #7001:
URL: https://github.com/apache/opendal/pull/7001#discussion_r2615224076
##########
core/layers/dtrace/src/lib.rs:
##########
Review Comment:
We need to move the file here instead instead of directly adding the files.
##########
core/src/lib.rs:
##########
@@ -72,6 +72,9 @@ pub mod layers {
pub use opendal_layer_await_tree::*;
#[cfg(feature = "layers-capability-check")]
pub use opendal_layer_capability_check::*;
+ #[cfg(all(target_os = "linux", feature = "layers-dtrace"))]
+ pub use opendal_layer_dtrace::DtraceLayer;
Review Comment:
We should expose as `opendal_layer_dtrace::*`;
##########
.gitignore:
##########
@@ -5,6 +5,7 @@
**/target
**/vendor
dist/
+*~
Review Comment:
We don't need this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
