Xuanwo commented on code in PR #7037:
URL: https://github.com/apache/opendal/pull/7037#discussion_r2625972428
##########
core/services/gridfs/src/config.rs:
##########
@@ -22,20 +22,14 @@ use serde::Serialize;
use super::backend::GridfsBuilder;
-/// Config for Grid file system support.
Review Comment:
I don't think we need those changes.
##########
core/core/Cargo.toml:
##########
@@ -159,8 +158,8 @@ hmac = { version = "0.12.1", optional = true }
# for services-moka
moka = { version = "0.12", optional = true, features = ["future", "sync"] }
# for services-mongodb
-mongodb = { version = "3.3.0", optional = true }
-mongodb-internal-macros = { version = "3.2.4", optional = true }
+mongodb = { workspace = true, optional = true }
Review Comment:
I think this dependency isn’t worth being at the workspace level, as it’s
only used by mongodb.
##########
core/Cargo.toml:
##########
@@ -47,6 +47,8 @@ ctor = "0.6"
futures = { version = "0.3", default-features = false }
http = "1.1"
log = "0.4"
+mongodb = "3.3.0"
Review Comment:
`opendal` doesn't need to depend on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
