Copilot commented on code in PR #7053:
URL: https://github.com/apache/opendal/pull/7053#discussion_r2626345997
##########
core/layers/timeout/Cargo.toml:
##########
@@ -0,0 +1,24 @@
+[package]
+description = "Apache OpenDAL timeout layer"
+name = "opendal-layer-timeout"
+
+authors = { workspace = true }
+edition = { workspace = true }
+homepage = { workspace = true }
+license = { workspace = true }
+repository = { workspace = true }
+rust-version = { workspace = true }
+version = { workspace = true }
+
+[package.metadata.docs.rs]
+all-features = true
+
+[dependencies]
+opendal-core = { path = "../../core", version = "0.55.0", default-features =
false }
+tokio = { workspace = true, features = ["time"] }
+
+[dev-dependencies]
+futures = { workspace = true }
+opendal-core = { path = "../../core", version = "0.55.0" }
+opendal-layer-retry = { path = "../retry", version = "0.55.0",
default-features = false }
Review Comment:
There's a circular dependency between the timeout and retry layers. The
timeout layer has `opendal-layer-retry` in dev-dependencies (line 23), while
the retry layer has `opendal-layer-timeout` in dev-dependencies (line 26). This
creates a circular dependency that could cause build issues. Consider removing
one of these test dependencies or restructuring the tests to avoid the circular
dependency.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
