Copilot commented on code in PR #7050:
URL: https://github.com/apache/opendal/pull/7050#discussion_r2628009535
##########
core/services/sqlite/Cargo.toml:
##########
@@ -31,10 +31,9 @@ version = { workspace = true }
all-features = true
[dependencies]
-opendal-core = { path = "../../core", version = "0.55.0", default-features =
false }
-
ctor = { workspace = true }
-mea = { version = "0.5.1" }
+mea = "0.5.1"
Review Comment:
Inconsistent formatting for the mea dependency. Some services use `mea =
"0.5.1"` (simplified format), while others use `mea = { version = "0.5.1" }`
(table format). For consistency, use the same format across all services. The
simplified format is preferred when only specifying a version.
##########
core/services/aliyun-drive/src/docs.md:
##########
@@ -21,18 +21,16 @@ This service can be used to:
- `refresh_token`: Set the refresh_token for backend.
- `drive_type`: Set the drive_type for backend.
-Refer to [`AliyunDriveBuilder`]`s public API docs for more information.
+Refer to [`AliyunDriveBuilder`]`s public API docs for more information.
Review Comment:
There's a typo in the documentation reference. It should be
`[`AliyunDriveBuilder`]'s` instead of `[`AliyunDriveBuilder`]`s` (the
apostrophe is outside the backticks incorrectly).
```suggestion
Refer to [`AliyunDriveBuilder`]'s public API docs for more information.
```
##########
core/services/persy/Cargo.toml:
##########
@@ -31,10 +31,12 @@ version = { workspace = true }
all-features = true
[dependencies]
+ctor = { workspace = true }
opendal-core = { path = "../../core", version = "0.55.0", default-features =
false, features = [
"internal-tokio-rt",
] }
Review Comment:
The persy service retains the "internal-tokio-rt" feature on opendal-core,
while similar services like redb and sled have removed this feature in this PR.
Consider removing this feature for consistency unless there's a specific
requirement for persy to use it.
##########
core/services/ftp/Cargo.toml:
##########
@@ -31,23 +31,19 @@ version = { workspace = true }
all-features = true
[dependencies]
-opendal-core = { path = "../../core", version = "0.55.0", default-features =
false }
-
bytes = { workspace = true }
ctor = { workspace = true }
fastpool = "1.0.2"
-futures = { workspace = true, default-features = false, features = [
- "std",
- "async-await",
-] }
+futures = { workspace = true, features = ["std", "async-await"] }
futures-rustls = "0.26.0"
http = { workspace = true }
log = { workspace = true }
+opendal-core = { path = "../../core", version = "0.55.0", default-features =
false }
rustls-native-certs = "0.8"
serde = { workspace = true, features = ["derive"] }
suppaftp = { version = "6.3.0", default-features = false, features = [
"async-secure",
"rustls",
"async-rustls",
] }
-tokio = { workspace = true, features = ["macros", "rt", "time"] }
+tokio = { workspace = true, features = ["macros", "rt-multi-thread", "time"] }
Review Comment:
The FTP service includes tokio with specific features in [dependencies], but
unlike other services in this PR, it doesn't add a separate [dev-dependencies]
section for testing features. The existing tokio dependency includes "macros"
and "rt-multi-thread" which are typically test-only features. Consider adding a
[dev-dependencies] section for consistency with other services being updated in
this PR.
##########
core/services/postgresql/Cargo.toml:
##########
@@ -31,9 +31,11 @@ version = { workspace = true }
all-features = true
[dependencies]
-opendal-core = { path = "../../core", version = "0.55.0", default-features =
false }
-
ctor = { workspace = true }
-mea = { version = "0.5.1" }
+mea = "0.5.1"
Review Comment:
Inconsistent formatting for the mea dependency. Some services use `mea =
"0.5.1"` (simplified format), while others use `mea = { version = "0.5.1" }`
(table format). For consistency, use the same format across all services. The
simplified format is preferred when only specifying a version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
