carlsverre commented on PR #7056:
URL: https://github.com/apache/opendal/pull/7056#issuecomment-3666600158
@Xuanwo throwing this up for discussion. It currently fails the
`test_retry_write_fail_on_close` here:
```rust
match w.close().await {
Ok(_) => (),
Err(_) => {
w.abort().await.unwrap();
}
};
```
But it seems that close/abort is somewhat inconsistent throughout. It seems
like most of the code expects that if close fails you don't need to call abort.
I'd like to understand what the actual intention of close vs abort is, and when
users are expected to call them. Then it may be worthwhile to enforce the
correct invariants in the CompleteWriter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
