Sahil-Shadwal commented on code in PR #7060: URL: https://github.com/apache/opendal/pull/7060#discussion_r2636885700
########## core/core/src/services/sftp/utils.rs: ########## Review Comment: Thanks for the review! The change from impl From to pub fn to_metadata is actually required, not a refactor. The original impl From<SftpMeta> for Metadata violates Rust's orphan rule once split into a separate crate (all three types are foreign). The code won't compile without this change. The "REMOVE ME" comment in the original code indicated this was already known to be problematic so what should i do ???? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
