Xuanwo commented on code in PR #7088:
URL: https://github.com/apache/opendal/pull/7088#discussion_r2640135327


##########
bindings/java/src/executor.rs:
##########
@@ -129,7 +129,7 @@ pub(crate) fn make_tokio_executor(env: &mut JNIEnv, cores: 
usize) -> Result<Exec
             move || {
                 ENV.with(|cell| {
                     let mut env = vm
-                        .attach_current_thread_permanently()
+                        .attach_current_thread_as_daemon()

Review Comment:
   I found that if we don't change this, the program will hang indefinitely in 
JMH.
   
   cc @tisonkun what do you think about this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to