Copilot commented on code in PR #7091: URL: https://github.com/apache/opendal/pull/7091#discussion_r2642230359
########## core/Cargo.toml: ########## @@ -160,8 +160,8 @@ services-pcloud = ["dep:opendal-service-pcloud"] services-persy = ["dep:opendal-service-persy"] services-postgresql = ["dep:opendal-service-postgresql"] services-redb = ["dep:opendal-service-redb"] -services-redis = ["opendal-core/services-redis"] -services-redis-native-tls = ["opendal-core/services-redis-native-tls"] +services-redis = ["opendal-service-redis?/rustls"] +services-redis-native-tls = ["opendal-service-redis?/native-tls"] Review Comment: The feature flags for `services-redis` and `services-redis-native-tls` are incorrect. Using `opendal-service-redis?/rustls` only tries to enable the `rustls` feature IF the dependency is already enabled, but doesn't actually enable the dependency itself. This means these features won't work as intended. The correct implementation should be: - `services-redis = ["dep:opendal-service-redis", "opendal-service-redis?/rustls"]` - `services-redis-native-tls = ["dep:opendal-service-redis", "opendal-service-redis?/native-tls"]` This ensures the dependency is enabled first with `dep:`, and then the appropriate TLS feature is selected. ```suggestion services-redis = ["dep:opendal-service-redis", "opendal-service-redis?/rustls"] services-redis-native-tls = ["dep:opendal-service-redis", "opendal-service-redis?/native-tls"] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
