Somsubhra-Nandi commented on PR #7114: URL: https://github.com/apache/opendal/pull/7114#issuecomment-3702599826
@meteorgan Updates: Refactor: I've extracted the URL generation logic into a helper function build_request_url as requested. Tests: Added unit tests to cover both root (/) and non-root paths, ensuring the URL structure is correct. Style: Ran cargo fmt to ensure compliance with the project's code style. Note on CI: I noticed the C Bindings and OCaml checks failed due to network timeouts (HTTP 504 / SSL handshake errors) while downloading dependencies. These seem unrelated to my changes in onedrive. Ready for review! > Thanks for your contribution. Could we add a test for this behavior ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
