dheeraj12347 commented on code in PR #7176:
URL: https://github.com/apache/opendal/pull/7176#discussion_r2757322584
##########
core/core/src/raw/ops.rs:
##########
@@ -133,6 +134,8 @@ pub struct OpList {
///
/// Default to `false`
deleted: bool,
+ /// The timeout for this operation.
+ timeout: Option<Duration>,
Review Comment:
> Thank you, but `Layer`'s behavior should never be injected into ops level.
Thank you for the feedback, @Xuanwo. I understand now that the ops level
should remain agnostic of Layer behaviors.
To support per-operation timeouts without injecting them into raw/ops.rs,
would you recommend using Operator::call with a custom context, or is there a
preferred pattern in OpenDAL for passing per-request configurations to Layers?
I'll revert the changes to ops.rs and refactor accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
