Xuanwo opened a new pull request, #702:
URL: https://github.com/apache/opendal-reqsign/pull/702
This PR replaces `async_trait`-based async trait methods with an
OpenDAL-style `MaybeSend` future model across reqsign. It keeps the
single-trait architecture while making wasm/non-wasm send bounds explicit
through shared future aliases.
To preserve object safety and existing ergonomics, this change introduces
`*Dyn` adapters (`HttpSendDyn`, `FileReadDyn`, `CommandExecuteDyn`,
`ProvideCredentialDyn`, `SignRequestDyn`) and keeps public builder APIs
(`Context`, `Signer`, provider chains) working with trait objects.
## Context
- Aligns reqsign with the same `MaybeSend` direction used by OpenDAL.
- Removes all `async-trait` usage and corresponding crate dependencies
across the workspace.
- Validation run:
- `cargo fmt --all --check`
- `cargo check --workspace`
- `cargo build --manifest-path reqsign/Cargo.toml --target
wasm32-unknown-unknown --no-default-features
--features=aws,azure,aliyun,tencent`
- `cargo test -p reqsign-core --doc`
- `cargo test -p reqsign-aws-v4 --doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]