dentiny commented on code in PR #7645:
URL: https://github.com/apache/opendal/pull/7645#discussion_r3328719180
##########
bindings/go/tests/behavior_tests/list_test.go:
##########
@@ -21,14 +21,46 @@ package opendal_test
import (
"fmt"
+ "os"
"slices"
+ "strconv"
"strings"
opendal "github.com/apache/opendal/bindings/go"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
)
+// capabilityOverrides is lazily parsed from OPENDAL_TEST_CAPABILITY_OVERRIDES.
+var parsedOverrides map[string]bool
+
+func getCapOverrides() map[string]bool {
+ if parsedOverrides != nil {
+ return parsedOverrides
+ }
+ raw := os.Getenv("OPENDAL_TEST_CAPABILITY_OVERRIDES")
+ parsedOverrides = make(map[string]bool)
+ if raw == "" {
+ return parsedOverrides
+ }
+ for _, pair := range strings.Split(raw, ",") {
+ pair = strings.TrimSpace(pair)
+ if pair == "" {
+ continue
+ }
+ kv := strings.SplitN(pair, "=", 2)
+ if len(kv) != 2 {
+ continue
+ }
+ v, err := strconv.ParseBool(strings.TrimSpace(kv[1]))
+ if err != nil {
Review Comment:
curious in unit test, what're the cases we would fail the parse?
##########
bindings/go/string_ownership_test.go:
##########
@@ -301,6 +323,54 @@ func TestListWithRecursiveFalse(t *testing.T) {
}
}
+func TestListWithVersionsDefaultFalse(t *testing.T) {
Review Comment:
I'm not sure why this test case is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
