potiuk commented on PR #7641: URL: https://github.com/apache/opendal/pull/7641#issuecomment-4713787967
Thanks @erickguan and @Xuanwo for the detailed review. On the credentials-after-fork topic: agreed it's out of scope — OpenDAL can't control what a forked child inherits, so we won't add guidance telling users to clear credentials after `fork` (per your call, @Xuanwo). We'll keep the in-scope framing instead: OpenDAL must not leak credentials between independent operators, services, or layers *within the same process*. On the rest: a number of the inline `suggestion` blocks now show as outdated against the current revision, so GitHub won't apply them cleanly anymore. Most were wording/structure tightenings (the §5.3 heading, the "we will revisit this model when…" phrasing, the backend/principal definitions). Could you take one more pass over the current text and re-flag anything still worth changing? I'll fold those in directly — happy to apply the tightenings, just want them anchored to the current version so nothing gets mis-applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
