YuangGao commented on code in PR #7637:
URL: https://github.com/apache/opendal/pull/7637#discussion_r3463918672
##########
core/services/webdav/src/backend.rs:
##########
@@ -153,6 +153,23 @@ impl WebdavBuilder {
}
self
}
+
+ /// Disable conditional read headers on GET requests.
+ ///
+ /// By default, OpenDAL advertises and sends the RFC 7232 headers
+ /// `If-Match`, `If-None-Match`, `If-Modified-Since` and
+ /// `If-Unmodified-Since` when callers ask for conditional reads.
+ ///
+ /// Some WebDAV-compatible servers (e.g., nginx-dav) don't return
+ /// ETags in PROPFIND or don't honor these conditions on GET.
+ /// Enable this option to drop the four `read_with_if_*` capabilities
+ /// so callers fail fast instead of silently losing the condition.
Review Comment:
fair point, the wording might be confusing. What I meant: the fail-fast is
local — `correctness_check` returns `Unsupported` before we ever hit the
server. Without the flag, nginx-dav just ignores If-Match and hands you a 200,
which is the "silently losing" part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
