This is an automated email from the ASF dual-hosted git repository.
Xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 73ba2c039 docs(services/s3): fix inverted comment on
disable_list_objects_v2 (#7820)
73ba2c039 is described below
commit 73ba2c039e84349162e1e53ae00daa1eea8977a7
Author: HelloKitty <[email protected]>
AuthorDate: Thu Jun 25 15:25:35 2026 +0800
docs(services/s3): fix inverted comment on disable_list_objects_v2 (#7820)
The first line of the doc comment said disabling list objects v2 makes
OpenDAL 'not use the older List Objects V1', which is the opposite of the
actual behavior. Setting disable_list_objects_v2 = true makes the backend
select S3ListerV1, i.e. it falls back TO the older List Objects V1.
Fix the wording to 'fall back to the older List Objects V1' to match the
code and the following sentence about legacy services not supporting V2.
---
core/services/s3/src/backend.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/core/services/s3/src/backend.rs b/core/services/s3/src/backend.rs
index fe939b974..624351c6c 100644
--- a/core/services/s3/src/backend.rs
+++ b/core/services/s3/src/backend.rs
@@ -404,7 +404,7 @@ impl S3Builder {
self
}
- /// Disable list objects v2 so that opendal will not use the older
+ /// Disable list objects v2 so that opendal will fall back to the older
/// List Objects V1 to list objects.
///
/// By default, OpenDAL uses List Objects V2 to list objects. However,
